Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the github actions from sigstore/scaffolding. #1699

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Mar 31, 2022

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Summary

Remove explicit sigstore/scaffolding installations + tests now that sigstore/scaffolding has a github action that we can use instead.

Ticket Link

Fixes

Release Note


Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

Merging #1699 (405dbe0) into main (b099136) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
- Coverage   29.43%   29.37%   -0.06%     
==========================================
  Files         141      141              
  Lines        8413     8429      +16     
==========================================
  Hits         2476     2476              
- Misses       5668     5684      +16     
  Partials      269      269              
Impacted Files Coverage Δ
pkg/cosign/tlog.go 4.31% <0.00%> (-0.24%) ⬇️
cmd/cosign/cli/verify/verify_blob.go 10.49% <0.00%> (-0.14%) ⬇️
pkg/cosign/verify.go 18.45% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b099136...405dbe0. Read the comment docs.

@vaikas vaikas merged commit 4ee24d6 into sigstore:main Mar 31, 2022
@github-actions github-actions bot added this to the v1.7.0 milestone Mar 31, 2022
@vaikas vaikas deleted the use-scaffolding-action branch April 1, 2022 20:02
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants