Fix fulcioroots test and linter error #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linter error is from a deprecated method, but since this is only used in tests and we don't use system roots, this is fine. The test was also failing because the TUF remote can't be called in tests. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
force-pushed
the
fixfulcioroots
branch
from
015386f
to
4d179e1
Compare
dlorenc
approved these changes
Apr 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
- Coverage 29.52% 29.46% -0.06%
==========================================
Files 141 141
Lines 8502 8502
==========================================
- Hits 2510 2505 -5
- Misses 5718 5726 +8
+ Partials 274 271 -3
Continue to review full report at Codecov.
|
hectorj2f
approved these changes
Apr 11, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
The linter error is from a deprecated method, but since this is only used in tests and we don't use system roots, this is fine. The test was also failing because the TUF remote can't be called in tests. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter error is from a deprecated method, but since this is only
used in tests and we don't use system roots, this is fine. The test was
also failing because the TUF remote can't be called in tests.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note