docs(readme): add installation steps for container image for cosign binary #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inary Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
dlorenc
previously approved these changes
Jun 10, 2022
README.md
Outdated
| ```shell | ||
| FROM gcr.io/projectsigstore/cosign:v1.9.0 as cosign-bin | ||
|
|
||
| FROM scratch |
There was a problem hiding this comment.
This will work, but then will the image actually be usable? You'd probably need ca-certs as well to actually talk to any registries at a minimum. Maybe we should use distroless in the example?
There was a problem hiding this comment.
That makes a lot of sense, let me update it before merge, thanks 🙏
There was a problem hiding this comment.
I think we are good with: acd342e
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Codecov Report
@@ Coverage Diff @@
## main #1986 +/- ##
=======================================
Coverage 28.71% 28.71%
=======================================
Files 132 132
Lines 8087 8087
=======================================
Hits 2322 2322
Misses 5458 5458
Partials 307 307 Continue to review full report at Codecov.
|
dlorenc
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
Summary
Adding installation steps for container image for cosign binary
Ticket Link
Fixes #1985
Release Note