Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OIDC test #2050

Merged
merged 7 commits into from Jul 6, 2022
Merged

Fix OIDC test #2050

merged 7 commits into from Jul 6, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jul 6, 2022

Summary

The test was missing some new flags and also the certificate that we use for self signing expired.

This PR update/fix the following things:

  • use cosign build from the head and not from a release
  • add a script to sign the digests and not the tags
  • update the test script and update the flags
  • regenerate the certificate because the previous one expired, now it is valid for 10 years
  • add doc on how to regenerate a certificate in case we need it again :)
  • enable go cache

test execution in the forked repo:

Release Note

NONE

Documentation

NONE

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
…lid for 10 years

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Copy link
Member Author

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it uses https://rekor.sigstore.dev/api/v1/log/entries should we point to the staging env?

test/sign_blob_test.sh Outdated Show resolved Hide resolved
@priyawadhwa
Copy link
Contributor

it uses https://rekor.sigstore.dev/api/v1/log/entries should we point to the staging env?

+1! I think it would be good to test against more recent versions of rekor before we update prod

Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Jul 6, 2022

it uses https://rekor.sigstore.dev/api/v1/log/entries should we point to the staging env?

+1! I think it would be good to test against more recent versions of rekor before we update prod

ok, we can do it in a follow up, then we can validate if this is working as expected :)

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #2050 (7d16021) into main (4ba8b6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2050   +/-   ##
=======================================
  Coverage   26.22%   26.22%           
=======================================
  Files         128      128           
  Lines        7539     7539           
=======================================
  Hits         1977     1977           
  Misses       5307     5307           
  Partials      255      255           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba8b6a...7d16021. Read the comment docs.

Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dlorenc dlorenc merged commit dbd430f into sigstore:main Jul 6, 2022
@github-actions github-actions bot added this to the v1.10.0 milestone Jul 6, 2022
@cpanato cpanato deleted the fix-oidc-test branch July 6, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants