Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nits for #2337 #2342

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Nits for #2337 #2342

merged 2 commits into from
Oct 14, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Oct 14, 2022

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Summary

There were couple of tiny nits on #2337 that I didn't get in on time, so this fixes them

Release Note

Documentation

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
priyawadhwa
priyawadhwa previously approved these changes Oct 14, 2022
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! Apparently I can't spell 😅😆

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

Merging #2342 (ae99bfd) into main (797033c) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2342   +/-   ##
=======================================
  Coverage   29.85%   29.85%           
=======================================
  Files         134      134           
  Lines        8287     8287           
=======================================
  Hits         2474     2474           
  Misses       5482     5482           
  Partials      331      331           
Impacted Files Coverage Δ
cmd/cosign/cli/options/verify.go 0.00% <ø> (ø)
cmd/cosign/cli/verify.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

hectorj2f
hectorj2f previously approved these changes Oct 14, 2022
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas vaikas dismissed stale reviews from hectorj2f and priyawadhwa via ae99bfd October 14, 2022 19:15
@vaikas vaikas enabled auto-merge (squash) October 14, 2022 19:22
@vaikas vaikas merged commit a7ad7e7 into sigstore:main Oct 14, 2022
@github-actions github-actions bot added this to the v1.14.0 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants