fix: cosign flags been ignored #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2353 +/- ##
==========================================
- Coverage 30.24% 30.20% -0.04%
==========================================
Files 136 136
Lines 8419 8429 +10
==========================================
Hits 2546 2546
- Misses 5542 5552 +10
Partials 331 331
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hectorj2f
force-pushed
the
fix_cosign_root_flags
branch
from
7874107
to
ad1aedc
Compare
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
hectorj2f
force-pushed
the
fix_cosign_root_flags
branch
from
ad1aedc
to
5356933
Compare
znewman01
approved these changes
Oct 18, 2022
cpanato
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hector Fernandez hector@chainguard.dev
Summary
I found that the root command flags were ignored due to spf13/cobra#216.
This was also detected in our tests here https://github.com/sigstore/cosign/actions/runs/3275334427/jobs/5390046355#step:7:446.
Release Note
Documentation