Replace accidentally-removed public constants #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2370 +/- ##
=======================================
Coverage 30.19% 30.19%
=======================================
Files 136 136
Lines 8432 8432
=======================================
Hits 2546 2546
Misses 5555 5555
Partials 331 331 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
These were removed in sigstore#2322, which made it an accidentally-semver-breaking change. This unbreaks semver. These should be removed at the next major version release or sooner if we decide keeping semver is not important. Signed-off-by: Zachary Newman <zjn@chainguard.dev>
znewman01
force-pushed
the
putbackconst
branch
from
e4824fb
to
ddb9592
Compare
hectorj2f
approved these changes
Oct 21, 2022
|
If no one complained it's probably fine to leave them out IMO. |
It hasn't shipped yet so nobody had an opportunity to complain 😛 My preference is to leave these in for now, but adopt a policy around versioning that let's us make breaking changes. Then we can make it clear in our versioning docs and then all bets are off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were removed in #2322, which made it an accidentally-semver-breaking change. This unbreaks semver.
These should be removed at the next major version release or sooner if we decide keeping semver is not important.
Signed-off-by: Zachary Newman zjn@chainguard.dev
Summary
Release Note
NONE
Documentation
N/A