Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Timestamp signing and verification #2499

Merged
merged 8 commits into from
Dec 7, 2022
Merged

Updates to Timestamp signing and verification #2499

merged 8 commits into from
Dec 7, 2022

Commits on Dec 6, 2022

  1. Updates to Timestamp signing and verification 

    * Switch to using the raw signature rather than base64 signature for OCI
  and blob signing
* For blob signing, write only the timestamp to disk, not the
  LocalSignedPayload (since that's already written with the bundle)
* For blob verification, expect only a timestamp in the file. If you
  don't pass a bundle, you'll need to also pass the signature by flag
* Some nits from the previous PR

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    25bcbad View commit details
    Browse the repository at this point in the history

  2. Add testing in verify, update e2e test 

    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    cb9c9cb View commit details
    Browse the repository at this point in the history

  3. Fix test 

    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    56fb38c View commit details
    Browse the repository at this point in the history

  4. Add missing setting of SkipTlogVerify 

    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    5f8e8bd View commit details
    Browse the repository at this point in the history

  5. Address comments 

    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    5acd7f6 View commit details
    Browse the repository at this point in the history

  6. Fix docs 

    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6fb95c9 View commit details
    Browse the repository at this point in the history

  7. Address nits 

    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ee0f511 View commit details
    Browse the repository at this point in the history

  8. Fix e2e test 

    Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
    @haydentherapper
    haydentherapper committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ae14708 View commit details
    Browse the repository at this point in the history