attest-blob: add functionality for keyless signing #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asraa
commented
Dec 6, 2022
asraa
commented
Dec 6, 2022
asraa
force-pushed
the
attest-blob-keyless
branch
3 times, most recently
from
e4a74f1
to
d0e2841
Compare
Codecov Report
@@ Coverage Diff @@
## main #2515 +/- ##
==========================================
- Coverage 30.79% 30.09% -0.70%
==========================================
Files 144 146 +2
Lines 8754 9113 +359
==========================================
+ Hits 2696 2743 +47
- Misses 5667 5961 +294
- Partials 391 409 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
asraa
force-pushed
the
attest-blob-keyless
branch
2 times, most recently
from
5282bf6
to
432c8f0
Compare
|
@znewman01 @priyawadhwa @haydentherapper PTAL! I added preliminary tests that are focused on key signing functionality and CLI functionality. I'll be going back to the verification piece of this too. |
asraa
force-pushed
the
attest-blob-keyless
branch
from
6ec1d76
to
1a12d4f
Compare
znewman01
previously approved these changes
Dec 9, 2022
asraa
force-pushed
the
attest-blob-keyless
branch
from
1a12d4f
to
8d8c066
Compare
|
Sorry for the delay, but rebased and comments addressed. |
znewman01
previously approved these changes
Dec 23, 2022
asraa
force-pushed
the
attest-blob-keyless
branch
from
8d8c066
to
a366bdf
Compare
znewman01
previously approved these changes
Jan 2, 2023
asraa
force-pushed
the
attest-blob-keyless
branch
from
a366bdf
to
40da2c4
Compare
Signed-off-by: Asra Ali <asraa@google.com> make tlog upload default true and always print cert in bundle Signed-off-by: Asra Ali <asraa@google.com> docgen Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
asraa
force-pushed
the
attest-blob-keyless
branch
from
3e98047
to
a8434a4
Compare
Signed-off-by: Asra Ali <asraa@google.com>
haydentherapper
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
I realized that the sign path didn't exist for keyless here, so it didn't make sense to implement #2389 before I did this one.
Summary
Release Note
attest-blobDocumentation