Allow users to pass in a path for the --identity-token flag #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2538 +/- ##
==========================================
- Coverage 30.11% 30.08% -0.04%
==========================================
Files 139 139
Lines 8597 8607 +10
==========================================
Hits 2589 2589
- Misses 5632 5642 +10
Partials 376 376
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Any concerns with this encouraging users to write ID tokens to files and risk token theft? |
priyawadhwa
force-pushed
the
identity-token-path
branch
from
0fb2a5a
to
70804c3
Compare
Seems cleaner to pass in a file name than to pass in an entire token. Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
priyawadhwa
force-pushed
the
identity-token-path
branch
from
70804c3
to
7d9f97c
Compare
|
@haydentherapper I can't think of anything compelling, doesn't seem much worse than passing in the token on the command line. |
dlorenc
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems cleaner to pass in a file name than to pass in an entire token.
Signed-off-by: Priya Wadhwa priya@chainguard.dev
Release Note
Allow users to pass in a path for the --identity-token flag