Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insecure-skip-tlog-verify: rename and adapt the cert expiration check #2620

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

hectorj2f
Copy link
Contributor

closes: #2590

Summary

Based on the discussion in #2590, we decided to rename the flag from insecure-skip-tlog-verify to insecure-ignore-tlog. Likewise, we also decided to throw an error expecting a signed timestamp whenever users ignore the tlog validation and no timestamp-rfc3161 was present.

Release Note

Documentation

Signed-off-by: Hector Fernandez <hector@chainguard.dev>
Signed-off-by: Hector Fernandez <hector@chainguard.dev>
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Merging #2620 (f3fca6f) into main (3a492c7) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
- Coverage   30.14%   30.13%   -0.01%     
==========================================
  Files         146      146              
  Lines        9252     9255       +3     
==========================================
  Hits         2789     2789              
- Misses       6032     6035       +3     
  Partials      431      431              
Impacted Files Coverage Δ
cmd/cosign/cli/options/verify.go 0.00% <0.00%> (ø)
cmd/cosign/cli/verify.go 0.00% <0.00%> (ø)
cmd/cosign/cli/verify/verify.go 22.49% <0.00%> (ø)
cmd/cosign/cli/verify/verify_attestation.go 3.43% <0.00%> (ø)
pkg/cosign/verify.go 39.36% <20.00%> (-0.14%) ⬇️
cmd/cosign/cli/verify/verify_blob.go 49.33% <100.00%> (ø)
cmd/cosign/cli/verify/verify_blob_attestation.go 33.64% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@priyawadhwa priyawadhwa mentioned this pull request Jan 11, 2023
3 tasks
priyawadhwa
priyawadhwa previously approved these changes Jan 11, 2023
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a comment nit, looks good!

Signed-off-by: Hector Fernandez <hector@chainguard.dev>
@hectorj2f hectorj2f marked this pull request as ready for review January 12, 2023 09:08
@cpanato cpanato merged commit 23d7a51 into sigstore:main Jan 12, 2023
@hectorj2f hectorj2f deleted the rename-flag branch January 12, 2023 09:47
@github-actions github-actions bot added this to the v1.14.0 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using --insecure-skip-tlog-verify possibly broken?
5 participants