verify-blob-attestation: Loosen arg requirements if --check-claims=false #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2746 +/- ##
==========================================
+ Coverage 29.03% 29.54% +0.50%
==========================================
Files 151 151
Lines 9642 9646 +4
==========================================
+ Hits 2800 2850 +50
+ Misses 6422 6357 -65
- Partials 420 439 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1. Update --check-claims documentation to better describe the behavior of the flag. 2. Modify verify-blob-attestation to not require a blob argument if --check-claims=false. This file is not used if we're not checking claims - it can be set to anything and still pass. Signed-off-by: Billy Lynch <billy@chainguard.dev>
wlynch
force-pushed
the
verify-blob-flag
branch
from
f5e631b
to
feb6305
Compare
priyawadhwa
approved these changes
Feb 28, 2023
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 24, 2023
…lse (sigstore#2746) 1. Update --check-claims documentation to better describe the behavior of the flag. 2. Modify verify-blob-attestation to not require a blob argument if --check-claims=false. This file is not used if we're not checking claims - it can be set to anything and still pass. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See https://sigstore.slack.com/archives/C01PZKDL4DP/p1677006107531799 for more discussion.
Release Note
--check-claims=falseis set.Documentation
✅