cli: update privacy statement and confirmation #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes an update to the privacy statement and confirmation notice in the CLI tool, intended to tie into the Hosted Project Tools policy from LF Projects, LLC (available at https://lfprojects.org/policies/). Signed-off-by: Steve Winslow <steve@swinslow.net>
haydentherapper
requested changes
Mar 14, 2023
haydentherapper
requested changes
Mar 14, 2023
Signed-off-by: Steve Winslow <steve@swinslow.net>
|
Hi @haydentherapper, I pushed 6650bf1 to tweak the wording to address the "Cosign service" and "attestation" points. For "personal data", I think this is the wording that LF would be inclined to use here. Does this address the concerns for the PR? Thank you! |
haydentherapper
previously approved these changes
Mar 14, 2023
| The sigstore service, hosted by sigstore a Series of LF Projects, LLC, is provided pursuant to the Hosted Project Tools Terms of Use, available at https://lfprojects.org/policies/hosted-project-tools-terms-of-use/. | ||
| Note that if your submission includes personal data associated with this signed artifact, it will be part of an immutable record. | ||
| This may include the email address associated with the account with which you authenticate your contractual Agreement. | ||
| This information will be used for signing this artifact and will be stored in public transparency logs and cannot be removed later, and is subject to the Immutable Record notice at https://lfprojects.org/policies/hosted-project-tools-immutable-records/.` |
There was a problem hiding this comment.
Can you move the backtick to a newline?
| This may include the email address associated with the account with which you authenticate your contractual Agreement. | ||
| This information will be used for signing this artifact and will be stored in public transparency logs and cannot be removed later, and is subject to the Immutable Record notice at https://lfprojects.org/policies/hosted-project-tools-immutable-records/.` | ||
|
|
||
| StatementConfirmation = "By typing 'y', you attest that (1) you are not submitting the personal data of any other person; and (2) you understand and agree to the statement and the Agreement terms at the URLs listed above.") |
There was a problem hiding this comment.
Can you lint the file?
There was a problem hiding this comment.
I've now run it through gofmt -s. Not seeing the goimports issue, but hoping it resolves now?
Apologies, I'm a bit more of a lawyer than a coder these days 🙃 I'm hoping it should pass this time, but grateful for anything you can do to point me in the right direction if it is still failing!
Codecov Report
@@ Coverage Diff @@
## main #2797 +/- ##
==========================================
+ Coverage 28.98% 29.51% +0.52%
==========================================
Files 151 151
Lines 9657 9657
==========================================
+ Hits 2799 2850 +51
+ Misses 6438 6368 -70
- Partials 420 439 +19 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Steve Winslow <steve@swinslow.net>
haydentherapper
approved these changes
Mar 14, 2023
bobcallaway
approved these changes
Mar 14, 2023
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 24, 2023
* cli: update privacy statement and confirmation This commit includes an update to the privacy statement and confirmation notice in the CLI tool, intended to tie into the Hosted Project Tools policy from LF Projects, LLC (available at https://lfprojects.org/policies/). Signed-off-by: Steve Winslow <steve@swinslow.net> * cli: tweak wording for revised privacy statement Signed-off-by: Steve Winslow <steve@swinslow.net> * cli: fix linting errors for privacy statement Signed-off-by: Steve Winslow <steve@swinslow.net> --------- Signed-off-by: Steve Winslow <steve@swinslow.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2796
Summary
This commit includes an update to the privacy statement and confirmation notice in the CLI tool, intended to tie into the Hosted Project Tools policy from LF Projects, LLC (available at https://lfprojects.org/policies/).
Release Note
Updated the privacy statement to align with the new Hosted Project Tools terms and notice from LF Projects, LLC
Documentation
N/A
cc @mkdolan for visibility