Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: date format of log should not show signatures #2835

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Makefile: date format of log should not show signatures #2835

merged 2 commits into from
Mar 25, 2023

Commits on Mar 25, 2023

  1. Makefile: date format of log should not show signatures 

    if user's have git configurations like `git config --global log.showSignature=true`
it will cause an issue in the Makefile variable output, like:
```shell
vbatts@possibly:~/src/github.com/sigstore/cosign$ make
[288/1916] /bin/sh: 1: Syntax error: "(" unexpected
CGO_ENABLED=0 go build -trimpath -ldflags "-buildid= -X sigs.k8s.io/release-utils/version.gitVersion=v2.0.0-63-ge71faa1a -X sigs.k8s.io/release-utils/version.gitCommit=e71faa1af0383d860481f569ef2c01694d37b00b -X sigs.k8s.io/release-utils/version.gitTreeState="clean" -X sigs.k8s.io/release-utils/version.buildDate=" -o cosign ./cmd/cosign
```

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    @vbatts
    vbatts committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    e4ca8b8 View commit details
    Browse the repository at this point in the history

  2. Makefile: add the ability to DEBUG the make build 

    Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
    @vbatts
    vbatts committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    2ed0492 View commit details
    Browse the repository at this point in the history