feat: consistent tlog warnings during verification #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes sigstore#2839 Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #2840 +/- ##
==========================================
- Coverage 29.51% 29.47% -0.04%
==========================================
Files 151 151
Lines 9666 9678 +12
==========================================
Hits 2853 2853
- Misses 6374 6386 +12
Partials 439 439
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dmitris
pushed a commit
to dmitris/cosign
that referenced
this pull request
Mar 27, 2023
Closes sigstore#2839 Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2839
Summary
This adds consistent warnings when using the
--insecure-ignore-tlogflag of the verification commands. The motivation is that if this is deemed an insecure practice, it should emit a warning whenever it is used.Release Note
NONE
Documentation
I don't think a documentation change is needed, but I'm happy to make one if deemed useful/necessary.