Use rekor signedEntryTimestamp if present #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2021 14:50
Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
priyawadhwa
force-pushed
the
bundle
branch
2 times, most recently
from
74741b9
to
f5e00d5
Compare
Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
added 2 commits
April 28, 2021 16:35
The TestTlog test was failing because it was going through this flow: 1. Sign and verify image 2. Turn on experimental feature 3. Sign and verify image again The second verification was failing with bundling because the deduper thought the image already existed, even though we were trying to tack on a new bundle annotation. This way, we can pass in extra annotations we want the deduper to check for before deciding the signature alrady exists. Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
dlorenc
reviewed
Apr 29, 2021
added 2 commits
April 29, 2021 10:21
- Only store SET and canonicalized payload in the bundle annotation - Add more bundle details to spec - Add details around updating the rekor public key Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
priyawadhwa
commented
Apr 29, 2021
dekkagaijin
previously requested changes
Apr 29, 2021
Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
|
Ehl gee tee emm! |
dlorenc
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the SET is present, we store the logEntry as a bundle annotation. On verify, we first try to verify it against the rekor public key (not experimental). if that fails, then we hit the tlog.
Starts to address #281, still need to add the
--verify-inclusionflag to force checking the tlog