feat: adds no cert found on sig exit code #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChrisJBurns <29541485+ChrisJBurns@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #3038 +/- ##
=======================================
Coverage 31.07% 31.08%
=======================================
Files 155 155
Lines 9732 9739 +7
=======================================
+ Hits 3024 3027 +3
- Misses 6247 6250 +3
- Partials 461 462 +1
|
|
Am wondering if the e2e tests are just failing due to flakiness? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the exit code and error type for when no certificate is found on a signature is thrown during verification.
Signed-off-by: ChrisJBurns 29541485+ChrisJBurns@users.noreply.github.com