Resolves #3088: version sub-command expected behaviour documentation and testing
#3447
+137
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partially addresses sigstore#3088 Signed-off-by: Omri Bornstein <omribor@gmail.com>
Signed-off-by: Omri Bornstein <omribor@gmail.com>
Signed-off-by: Omri Bornstein <omribor@gmail.com>
AppleGamer22
changed the title
version sub-command expected behaviour documentation and testingversion sub-command expected behaviour documentation and testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3447 +/- ##
==========================================
+ Coverage 30.38% 40.09% +9.70%
==========================================
Files 155 155
Lines 9982 9982
==========================================
+ Hits 3033 4002 +969
+ Misses 6497 5494 -1003
- Partials 452 486 +34 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Omri Bornstein <omribor@gmail.com>
Signed-off-by: Omri Bornstein <omribor@gmail.com>
Signed-off-by: Omri Bornstein <omribor@gmail.com>
auto-merge was automatically disabled
December 20, 2023 00:24
Head branch was pushed to by a user without write access
haydentherapper
previously approved these changes
Dec 20, 2023
Signed-off-by: Omri Bornstein <omribor@gmail.com>
cpanato
approved these changes
Dec 20, 2023
haydentherapper
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cosign versionoutput #3088versionsub-commandversionsub-command outputRelease Note
NONE
Documentation
The documentation of the
versionsub-command was updated such that the expected behaviour of printing to STDOUT is described.