Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CertSubject function #3467

Merged
merged 1 commit into from Jan 3, 2024

Conversation

haydentherapper
Copy link
Contributor

There is an existing function that handles more certificate subject types.

Summary

Release Note

Documentation

There is an existing function that handles more certificate subject
types.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e678426) 40.09% compared to head (04dc85b) 40.04%.

Files Patch % Lines
cmd/cosign/cli/verify/verify.go 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3467      +/-   ##
==========================================
- Coverage   40.09%   40.04%   -0.05%     
==========================================
  Files         155      155              
  Lines        9982     9979       -3     
==========================================
- Hits         4002     3996       -6     
- Misses       5494     5497       +3     
  Partials      486      486              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@haydentherapper haydentherapper merged commit daf1eeb into sigstore:main Jan 3, 2024
28 checks passed
@github-actions github-actions bot added this to the v2.3.0 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants