add documentation for new environment variable for Vault KMS support #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentrax
reviewed
Jun 9, 2021
KMS.md
Outdated
| @@ -99,3 +99,9 @@ $ export VAULT_ADDR=http://localhost:8200 | |||
| $ export VAULT_TOKEN=testtoken | |||
| $ vault secrets enable transit | |||
| ``` | |||
|
|
|||
| If you enabled `transit` secret engine at different path with the use of `-path` flag like `vault secrets enable -path="someotherpath" transit`, you can use `TRANSIT_SECRET_ENGINE_PATH` environment variable to specify this path while generating a key pair like the following: | |||
There was a problem hiding this comment.
like
vault secrets enable -path="someotherpath" transit
I think it's better to refactor here:
(i.e.,
$ vault secrets enable -path="someotherpath" transit)
🤔
There was a problem hiding this comment.
@Dentrax yes definitely, done.
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
dlorenc
approved these changes
Jun 9, 2021
|
Thank you so much for merging the PR @dlorenc ❤️🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
We recently added support for storing key pairs at the different paths for
Transit Secret Engineat this PR while using KMS support.cc: @Dentrax