Updated v1 to support latest version of go-tuf #3597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cpanato <ctadeu@gmail.com> Signed-off-by: cpanato <ctadeu@gmail.com>
* Merge pull request from GHSA-vfp6-jrw2-99g9 * Add limit to number of sigs and attestations Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com> * Update pkg/cosign/fetch.go Co-authored-by: Cody Soyland <codysoyland@gmail.com> Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com> * Update error message Signed-off-by: Hayden B <hblauzvern@google.com> * fix compilation error Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> * Add e2e tests Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> --------- Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com> Signed-off-by: Hayden B <hblauzvern@google.com> Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> Co-authored-by: Cody Soyland <codysoyland@gmail.com> Co-authored-by: Hayden B <hblauzvern@google.com> * fix missing import Signed-off-by: cpanato <ctadeu@gmail.com> * bump golang to 1.19.13 Signed-off-by: cpanato <ctadeu@gmail.com> * update tests Signed-off-by: cpanato <ctadeu@gmail.com> * refactor validate release Signed-off-by: cpanato <ctadeu@gmail.com> * pin sigstore/scaffolding/actions/setup to v0.4.13 Signed-off-by: cpanato <ctadeu@gmail.com> * update ko-local Signed-off-by: cpanato <ctadeu@gmail.com> --------- Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com> Signed-off-by: Hayden B <hblauzvern@google.com> Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> Signed-off-by: cpanato <ctadeu@gmail.com> Co-authored-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com> Co-authored-by: Cody Soyland <codysoyland@gmail.com> Co-authored-by: Hayden B <hblauzvern@google.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.0-fork #3597 +/- ##
============================================
- Coverage 30.16% 29.75% -0.42%
============================================
Files 136 137 +1
Lines 8436 8553 +117
============================================
Hits 2545 2545
- Misses 5561 5678 +117
Partials 330 330 ☔ View full report in Codecov by Sentry. |
kommendorkapten
commented
Mar 13, 2024
| @@ -100,7 +100,7 @@ lint: golangci-lint ## Run golangci-lint linter | |||
| $(GOLANGCI_LINT_BIN) run -n | |||
|
|
|||
| test: | |||
| go test $(shell go list ./... | grep -v third_party/) | |||
| GODEBUG=x509sha1=1 go test $(shell go list ./... | grep -v third_party/) | |||
There was a problem hiding this comment.
This is needed as some test certs are using SHA-1.
|
I'm not super familiar with cosign (like what v1 is) but does this mean upgrading cosign to use the go-tuf rewrite? EDIT: I suppose 0.7 is the release before the rewrite? |
Correct! This is the last version that is API compatible. |
|
LGTM, just need to rebase off release-1.13 and merge into that branch instead, which should hopefully resolve test failures. |
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
swap out deprecated lib Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
swap out deprecated lib Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
fix gofmt issue Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
go mod tidy Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
free up space ahead of running goreleaser Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
kommendorkapten
force-pushed
the
v1-go-tuf-update
branch
from
fbe758d
to
be9bf89
Compare
|
Rebased on |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per the latest TUF updates in Sigstore Public Good instance, the key type is changing for the TUF keys, to keep cosign v1 continue to work I've updated to the latest go-tuf version.
Release Note
Documentation
N/A