add flags to specify slot, PIN, and touch policies for security keys #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permits flexibility to use different PIN and touch policies for container signing. Key generation will use the default PIN and touch policies for the specified slot unless additional flags are set to attempt to override the default. The security key is not guaranteed to honor a particular PIN and touch policy for the specified slot. Signed-off-by: Dino A. Dai Zovi <ddz@theta44.org>
|
Nice! Just pulled your branch and ran the yubikey tests that don't work in CI: $ go test ./test -tags=resetyubikey,e2e,pivkey -count=1
ok github.com/sigstore/cosign/test 19.086s |
dlorenc
approved these changes
Jun 14, 2021
|
Thank you for the quick response and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permits flexibility to use different PIN and touch policies
for container signing. Key generation will use the default PIN
and touch policies for the specified slot unless additional flags
are set to attempt to override the default. The security key is
not guaranteed to honor a particular PIN and touch policy for the
specified slot.
Signed-off-by: Dino A. Dai Zovi ddz@theta44.org