Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor insecure registry E2E tests #3701

Merged
merged 6 commits into from
May 17, 2024
Merged

Refactor insecure registry E2E tests #3701

merged 6 commits into from
May 17, 2024

Commits on May 16, 2024

  1. Fix e2e test copypaste error 

    Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
    @cmurphy
    cmurphy committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6737e88 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Clean up kind-e2e-insecure-registry workflow 

    - These tests don't use KinD, don't set it up
- Don't install yq, ko, or kustomize
- The scripts build cosign, no need to build it in its own step
- Don't use global environment variables when they're only needed for
  individual steps

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
    @cmurphy
    cmurphy committed May 17, 2024
    Configuration menu
    Copy the full SHA
    d675958 View commit details
    Browse the repository at this point in the history

  2. Move insecure OCI 1.0 registry tests to Go suite 

    Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
    @cmurphy
    cmurphy committed May 17, 2024
    Configuration menu
    Copy the full SHA
    4c81164 View commit details
    Browse the repository at this point in the history

  3. Move insecure OCI 1.1 registry tests to Go suite 

    Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
    @cmurphy
    cmurphy committed May 17, 2024
    Configuration menu
    Copy the full SHA
    0dd7725 View commit details
    Browse the repository at this point in the history

  4. Make registry tests hermetic 

    Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
    @cmurphy
    cmurphy committed May 17, 2024
    Configuration menu
    Copy the full SHA
    2bc7bb9 View commit details
    Browse the repository at this point in the history

  5. Move insecure registry workflow to e2e tests 

    Condense the kind-e2e-insecure-registry workflow into the rest of the
E2E tests workflow. The workflow name was misleading because these tests
don't relate to KinD except as an implementation detail of the
scaffolding action. Combining it makes it more discoverable and reduces
clutter inthe GitHub Actions UI.

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
    @cmurphy
    cmurphy committed May 17, 2024
    Configuration menu
    Copy the full SHA
    1c76303 View commit details
    Browse the repository at this point in the history