Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug providers command. #3728

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

wlynch
Copy link
Member

@wlynch wlynch commented Jun 10, 2024

Summary

When trying to run cosign on a remote workstation it would be nice to have a command to confirm the OIDC provider behavior of what is/isn't enabled and in what order.

This PR adds a new hidden debug subcommand, with a debug providers subcommand that prints out the list of orderd providers and whether or not they are enabled.

Fixes #3727

Release Note

Added cosign debug providers subcommand for showing which OIDC providers are enabled in the environment.

Documentation

n/a (intentionally hiding debug commands)

@cpanato
Copy link
Member

cpanato commented Jun 10, 2024

Plase check the boilerplate and sign the dco 😄

@wlynch wlynch force-pushed the export-providers branch 2 times, most recently from 62c45fe to eb1e53f Compare June 10, 2024 17:49
@wlynch
Copy link
Member Author

wlynch commented Jun 10, 2024

Done!

When trying to run cosign on a remote workstation it would be nice to
have a command to confirm the OIDC provider behavior of what is/isn't
enabled and in what order.

This PR adds a new hidden debug subcommand, with a debug providers
subcommand that prints out the list of orderd providers and whether
or not they are enabled.

Signed-off-by: Billy Lynch <billy@chainguard.dev>
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 40.24%. Comparing base (2ef6022) to head (b96f2a9).
Report is 122 commits behind head on main.

Files Patch % Lines
cmd/cosign/cli/debug.go 64.70% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3728      +/-   ##
==========================================
+ Coverage   40.10%   40.24%   +0.14%     
==========================================
  Files         155      158       +3     
  Lines       10044    10175     +131     
==========================================
+ Hits         4028     4095      +67     
- Misses       5530     5597      +67     
+ Partials      486      483       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato merged commit ca1733a into sigstore:main Jun 11, 2024
21 checks passed
@github-actions github-actions bot added this to the v2.3.0 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC provider debugging
3 participants