Fix/verify dockerfile parser #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Furkan <furkan.turkal@trendyol.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
developer-guy
force-pushed
the
fix/verify-dockerfile-parser
branch
from
df6994a
to
ef0cf87
Compare
dekkagaijin
reviewed
Jul 16, 2021
cmd/cosign/cli/verify_dockerfile.go
Outdated
| line = strings.Split(line, " AS ")[0] // Remove the "AS" portion of line | ||
| line = strings.TrimPrefix(line, "FROM") // Remove "FROM" prefix | ||
| line = os.ExpandEnv(line) // Substitute templated vars | ||
| line = strings.ReplaceAll(line, "as", "AS") // replace lower "as" with "AS" |
There was a problem hiding this comment.
this would substitute all instances of "as". I'm not sure if image names are case sensitive, but URL paths can be
|
ping |
dekkagaijin
approved these changes
Jul 21, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #430
Parser now replace the
askeyword toASbefore moving into the splitting function.