Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add well-known attestation specs support to the attest command #504

Merged
merged 3 commits into from
Jul 29, 2021
Merged

add well-known attestation specs support to the attest command #504

merged 3 commits into from
Jul 29, 2021

Conversation

developer-guy
Copy link
Member

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Fixes #472

Screen Shot 2021-07-29 at 00 29 03
Screen Shot 2021-07-29 at 00 20 11

Known Limitations:

  • We don't add support for SPDX predicate yet, because of that:

Currently not implemented. Some tooling exists here:
https://github.com/spdx/tools-golang, but this software is still in
early state.

cc: @Dentrax

@developer-guy
add well-known attestation specs support to the attest command
068d500 
Fixes sigstore#472

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
dlorenc
dlorenc reviewed Jul 29, 2021
View reviewed changes
Copy link
Member

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good once you get the lint errors cleaned up! Nice job with reflection :)

@developer-guy
fix lint issues, fix required json tag logic
8358a10 
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@developer-guy
Copy link
Member Author

This looks good once you get the lint errors cleaned up! Nice job with reflection :)

thank you so much, but we copied over the code from the in-toto-golang module because that it is a private method, to be honest. Let's remember Kelsey Hightower's words: Good developers copy, great developers paste! 😅😅😅
cc: @Dentrax

@developer-guy
fix e2e test and license problems
bfad7bd 
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@dlorenc dlorenc merged commit 7e9cdfb into sigstore:main Jul 29, 2021
@developer-guy developer-guy mentioned this pull request Jul 30, 2021
Closed
@cpanato cpanato added this to the v1.1.0 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Feature: Add support for custom attestation predicate types
3 participants
@developer-guy @dlorenc @cpanato