Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify ignore scratch images #509

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Conversation

rjbrown57
Copy link
Contributor

Fixes #508

cmd/cosign/cli/verify.go Outdated Show resolved Hide resolved
@dekkagaijin
Copy link
Member

Is there a use-case where "scratch" is being verified directly with verify? Or is meant to fix an issue with verify-dockerfile? If the latter, it'd be better to patch that command. FWIW I thought I had already special-cased FROM scratch in verify-dockerfile but I was clearly mistaken

@rjbrown57
Copy link
Contributor Author

Is there a use-case where "scratch" is being verified directly with verify? Or is meant to fix an issue with verify-dockerfile? If the latter, it'd be better to patch that command. FWIW I thought I had already special-cased FROM scratch in verify-dockerfile but I was clearly mistaken

At least when a user is running with docker and "scratch" defaults to "https://index.docker.io/v2/library/scratch" I don't think anyone will run verify scratch.

Would it make more sense to filter somewhere in https://github.com/sigstore/cosign/blob/main/cmd/cosign/cli/verify_dockerfile.go#L115?

@rjbrown57
Copy link
Contributor Author

Updated to ignore scratch in verify-dockerfile

Signed-off-by: Russell Brown <rjbrown57@gmail.com>
@dlorenc dlorenc merged commit 4877fbb into sigstore:main Jul 30, 2021
@cpanato cpanato added this to the v1.1.0 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verify-dockerfile Does not appropriately handle scratch images.
4 participants