Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'cosign init' minor enhancements (file or URL root, write to $HOME/.sigstore) #530

Merged
merged 5 commits into from
Aug 11, 2021

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Aug 10, 2021

Signed-off-by: Asra Ali asraa@google.com

Makes two minor changes to cosign init behavior:

  • Writes the resulting metadata to the home directory
  • Allows users to specify a file or URL that defaults to the github repository mirror for the initial trusted root metadata

Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa requested a review from dlorenc August 10, 2021 13:31
cmd/cosign/cli/init.go Outdated Show resolved Hide resolved
@cpanato cpanato added this to the v1.1.0 milestone Aug 10, 2021
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
pkg/cosign/tuf/client.go Outdated Show resolved Hide resolved
@dlorenc
Copy link
Member

dlorenc commented Aug 10, 2021

I think there's one unused variable, lgtm either way!

Signed-off-by: Asra Ali <asraa@google.com>
@dlorenc dlorenc merged commit 4c76ff3 into sigstore:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants