Pinned the dockerfile to sha256 #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveensrinivasan
force-pushed
the
naveen/feat/fix-docker-digest
branch
from
42236b0
to
f5f1897
Compare
The dockerfile was referring to the tag. It is recommended to use pinned dependencies based on SHA https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies Changed the go:1.17 to SHA256 digest. This still works with dependabot. Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
naveensrinivasan
force-pushed
the
naveen/feat/fix-docker-digest
branch
from
f5f1897
to
7bc8fd2
Compare
|
Cc @cpanato can we just delete these Dockerfiles? Are they used anywhere? |
It is used https://github.com/sigstore/cosign/search?q=Dockerfile |
|
@dlorenc @naveensrinivasan the file the other |
|
yep we use here: https://github.com/sigstore/cosign/blob/main/release/cloudbuild.yaml#L69-L74 why we have the docker files is because if I need to build the image locally (mac or windows) the cross-compilation does not work |
dlorenc
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dockerfile was referring to the tag. It is recommended to use pinned
dependencies based on SHA https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies
Changed the go:1.17 to SHA256 digest. This still works with dependabot.