Move LoadEcdsa... into pkg/cosign/keys.go
#667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, left in some bonus (dead) code. |
Chains is consuming this public function, but because `./cmd/cosign/cli` pulls in `glog` we hit the `-log_dir` problem. With this change it can drop it's dependency on `cli`. Signed-off-by: Matt Moore <mattomata@gmail.com>
mattmoor
force-pushed
the
move-load-ecdsa
branch
from
cb09eac
to
d27f70c
Compare
|
Should be cleaned up. |
dekkagaijin
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chains is consuming this public function, but because
./cmd/cosign/clipulls inglogwe hit the-log_dirproblem. With this change it can drop it's dependency oncli.Signed-off-by: Matt Moore mattomata@gmail.com
cc @priyawadhwa @dlorenc @dekkagaijin