Make changes to Sigstore initialize #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asraa
force-pushed
the
make-changes-cosign-init
branch
2 times, most recently
from
f7021c8
to
301ac22
Compare
asraa
changed the title
asraa
force-pushed
the
make-changes-cosign-init
branch
2 times, most recently
from
182246e
to
d02ca31
Compare
|
This is ready for review now |
dekkagaijin
reviewed
Sep 28, 2021
| panic("error creating root cert pool") | ||
| } | ||
| if err := tuf.GetTarget(ctx, fulcioTargetStr, &buf); err != nil { | ||
| panic(errors.Wrap(err, "creating root cert pool")) |
There was a problem hiding this comment.
Is there a reason why we're using panics instead of errors in this package?
There was a problem hiding this comment.
This really shouldn't happen, but I'm not sure -- kind of was following existing code. We really should be getting these targets for any cosign verification, most of the callers expect these targets to be available.
I can plumb through errors, but it'll touch a bit of code
|
So sorry, I moved these files to keep them isolated. Can you rebase? |
|
updated! |
|
Looks like there's still a conflict :( |
asraa
force-pushed
the
make-changes-cosign-init
branch
from
d02ca31
to
2f75e70
Compare
|
because somehow i never pushed :P thanks! |
|
Looks like just a few lint errors now! |
asraa
force-pushed
the
make-changes-cosign-init
branch
from
2f75e70
to
ff9ee03
Compare
Signed-off-by: Asra Ali <asraa@google.com>
asraa
force-pushed
the
make-changes-cosign-init
branch
from
ff9ee03
to
c160e42
Compare
dlorenc
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Summary
Ticket Link
Fixes
Release Note
cosign initializeis explicitly run to check for updates (or a new root is provided)