Add sget to the goreleaser release pipeline #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
|
fyi, sget is migrating to sigstore/sget , but will have added fulcio TUF polices. |
|
we can move the goreleaser config together as well |
dekkagaijin
reviewed
Sep 22, 2021
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| ARG RUNTIME_IMAGE=gcr.io/distroless/base:debug |
There was a problem hiding this comment.
this is only going to be compatible with x86(-64)
There was a problem hiding this comment.
For the release we ise this gcr.io/distroless/static:debug-nonroot
This also is only for x86?
I built locally and that built for arm.
Vut can we replace that or should we drop the arm for container?
Thanks for the review!
There was a problem hiding this comment.
You're right, I forgot we made the arch-y images multi-arch
dekkagaijin
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up of: #745
Now we add the sget in the goreleaser config to release officially
sgetTicket Link
N/A
Release Note