Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework cosign.Verify to specify what's verified. #782

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

mattmoor
Copy link
Member

Previously, this was always Signatures(), but which sense of "signature" was nebulous (e.g. .sig, .att).

With this change, the interface here changes to take and accessor so folks explicitly specify which one they want, and I exposed Verify{Signatures,Attestations} methods with identical function signatures to what we exposed previously.

After this change, the only usage of ociremote.WithSignatureSuffix is some logic that deals with SBOMs, which it abusing things a bit, and the whole "attachment" thing is one of the next things I'm going to look at adding some abstraction for.

Signed-off-by: Matt Moore mattomata@gmail.com

Ticket Link

Related: #666

Release Note

Changes the function signature of `cosign.Verify` so callers must be explicit about which signatures (or attestations) to verify.  For matching signatures, see also `cosign.Verify{Signatures,Attestations}`.

Previously, this was always `Signatures()`, but which sense of "signature" was nebulous (e.g. `.sig`, `.att`).

With this change, the interface here changes to take and accessor so folks explicitly specify which one they want, and I exposed `Verify{Signatures,Attestations}` methods with identical function signatures to what we exposed previously.

After this change, the only usage of `ociremote.WithSignatureSuffix` is some logic that deals with SBOMs, which it abusing things a bit, and the whole "attachment" thing is one of the next things I'm going to look at adding some abstraction for.

Related: sigstore#666
Signed-off-by: Matt Moore <mattomata@gmail.com>
@dekkagaijin dekkagaijin merged commit b22a7b1 into sigstore:main Sep 24, 2021
@github-actions github-actions bot added this to the v1.3.0 milestone Sep 24, 2021
@mattmoor mattmoor deleted the verify-attestation branch September 24, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants