Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate k8schain to authenticate digest resolution. #804

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

mattmoor
Copy link
Member

k8schain implements a GGCR keychain that attempts to replicate the authentication done by the kubelet when pulling container images. It supports ambient credentials (e.g. GCE/AWS's http://metadata) as well as imagePullSecret resolution, and is also currently used by Tekton and Knative for similar purposes.

Signed-off-by: Matt Moore mattomata@gmail.com

Ticket Link

Fixes: #801

Release Note

The cosigned webhook now supports resolving private images that are authenticated via imagePullSecrets.

`k8schain` implements a GGCR keychain that attempts to replicate the authentication done by the kubelet when pulling container images.  It supports ambient credentials (e.g. GCE/AWS's `http://metadata`) as well as `imagePullSecret` resolution, and is also currently used by Tekton and Knative for similar purposes.

Fixes: sigstore#801
Signed-off-by: Matt Moore <mattomata@gmail.com>
@mattmoor mattmoor merged commit a42b124 into sigstore:main Sep 27, 2021
@mattmoor mattmoor deleted the k8schain branch September 27, 2021 16:18
@github-actions github-actions bot added this to the v1.3.0 milestone Sep 27, 2021
mrjoelkamp pushed a commit to mrjoelkamp/cosign that referenced this pull request Sep 27, 2021
`k8schain` implements a GGCR keychain that attempts to replicate the authentication done by the kubelet when pulling container images.  It supports ambient credentials (e.g. GCE/AWS's `http://metadata`) as well as `imagePullSecret` resolution, and is also currently used by Tekton and Knative for similar purposes.

Fixes: sigstore#801
Signed-off-by: Matt Moore <mattomata@gmail.com>
Signed-off-by: Joel Kamp <joel.kamp@invitae.com>
mrjoelkamp pushed a commit to mrjoelkamp/cosign that referenced this pull request Sep 28, 2021
`k8schain` implements a GGCR keychain that attempts to replicate the authentication done by the kubelet when pulling container images.  It supports ambient credentials (e.g. GCE/AWS's `http://metadata`) as well as `imagePullSecret` resolution, and is also currently used by Tekton and Knative for similar purposes.

Fixes: sigstore#801
Signed-off-by: Matt Moore <mattomata@gmail.com>
Signed-off-by: Joel Kamp <joel.kamp@invitae.com>
mrjoelkamp pushed a commit to mrjoelkamp/cosign that referenced this pull request Sep 28, 2021
`k8schain` implements a GGCR keychain that attempts to replicate the authentication done by the kubelet when pulling container images.  It supports ambient credentials (e.g. GCE/AWS's `http://metadata`) as well as `imagePullSecret` resolution, and is also currently used by Tekton and Knative for similar purposes.

Fixes: sigstore#801
Signed-off-by: Matt Moore <mattomata@gmail.com>
Signed-off-by: Joel Kamp <joel.kamp@invitae.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cosigned should use k8schain to support imagePullSecrets
2 participants