Fix issue #802, validate cronjobs #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ville Aikas <vaikas@gmail.com>
mattmoor
changed the title
Signed-off-by: Ville Aikas <vaikas@gmail.com>
Signed-off-by: Ville Aikas <vaikas@gmail.com>
Signed-off-by: Ville Aikas <vaikas@gmail.com>
Signed-off-by: Ville Aikas <vaikas@gmail.com>
Signed-off-by: Ville Aikas <vaikas@gmail.com>
|
The e2e tests are not being kind to you :3 |
hectorj2f
reviewed
Sep 28, 2021
Signed-off-by: Ville Aikas <vaikas@gmail.com>
Signed-off-by: Ville Aikas <vaikas@gmail.com>
dekkagaijin
approved these changes
Sep 28, 2021
vaikas
changed the title
hectorj2f
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #802
Validate CronJob images. Since v1 CronJob is fairly new and not available, also validate v1beta1.
Since knative.dev/pkg now requires k8s 1.20+, I dropped the matrix tests for it.
Ticket Link
Fixes
Release Note