Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fulcio integration! #83

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Fulcio integration! #83

merged 1 commit into from
Mar 15, 2021

Conversation

dlorenc
Copy link
Member

@dlorenc dlorenc commented Mar 12, 2021

This is a rebased/squashed version of #53 - getting closer to ready for review.

@dlorenc dlorenc force-pushed the rebasefulc branch 5 times, most recently from 48676b0 to baf1913 Compare March 13, 2021 15:21
lukehinds
lukehinds approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor comments, but I am honestly good to see this merge and get folks using it and feeding back.

KEYLESS.md Show resolved Hide resolved
cmd/cosign/cli/sign.go Show resolved Hide resolved
pkg/cosign/fulcio/fulcio.go Show resolved Hide resolved
pkg/cosign/remote.go Show resolved Hide resolved
@dlorenc dlorenc mentioned this pull request Mar 15, 2021
Closed
@dlorenc dlorenc force-pushed the rebasefulc branch 2 times, most recently from 0f42808 to cda3eec Compare March 15, 2021 15:53
priyawadhwa
priyawadhwa approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few nits, no need to address them if you wanna merge!

cmd/cosign/cli/verify.go Outdated Show resolved Hide resolved
cmd/cosign/cli/verify.go Outdated Show resolved Hide resolved
cmd/cosign/cli/verify_blob.go Outdated Show resolved Hide resolved
cmd/cosign/cli/verify_blob.go Outdated Show resolved Hide resolved
pkg/cosign/fetch.go Show resolved Hide resolved
pkg/cosign/verify.go Outdated Show resolved Hide resolved
test/e2e_test.go Show resolved Hide resolved
test/e2e_test.go Outdated Show resolved Hide resolved
@dlorenc
Copy link
Member Author

dlorenc commented Mar 15, 2021

Thanks!

Fulcio integration
a84b69e 
Signed-off-by: Dan Lorenc <dlorenc@google.com>
@dlorenc dlorenc changed the title WIP: Fulcio integration! Fulcio integration! Mar 15, 2021
@dlorenc dlorenc merged commit 561f8f2 into sigstore:main Mar 15, 2021
@dlorenc dlorenc deleted the rebasefulc branch March 15, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehinds lukehinds lukehinds approved these changes

@priyawadhwa priyawadhwa priyawadhwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dlorenc @lukehinds @priyawadhwa