Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix FAQ link to Signing Blobs #188

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Almad
Copy link

@Almad Almad commented Jun 12, 2023

Summary

Doc link results in 404.

Release Note

NONE

Documentation

This PR implements the doc change.

Signed-off-by: Almad <44565+Almad@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for docssigstore ready!

Name Link
🔨 Latest commit d282370
🔍 Latest deploy log https://app.netlify.com/sites/docssigstore/deploys/6488a8a159747e00081d23e8
😎 Deploy Preview https://deploy-preview-188--docssigstore.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@ltagliaferri ltagliaferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this broken link. Let's convert it to the full path vs. the relative path please.

content/en/cosign/FAQ.md Outdated Show resolved Hide resolved
Co-authored-by: ltagliaferri <lisa.tagliaferri@gmail.com>
Signed-off-by: Almad <44565+Almad@users.noreply.github.com>
@Almad
Copy link
Author

Almad commented Jun 15, 2023

(Accepted)

@Almad Almad requested a review from ltagliaferri June 15, 2023 15:59
@smythp
Copy link
Collaborator

smythp commented Aug 28, 2023

Hey @ltagliaferri, it looks like the part of the docs that this updated has been nuked during the reorg. I think it would be a shame if @Almad didn't get to merge in. I could create a new PR that includes this commit and resolves the merge conflict (though, really, there's no link to update anymore). We could also close this PR, with our apologies.

Thank you again for this helpful PR, and apologies for the reshuffle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants