Skip to content

Commit

Permalink
Update comment to specify support public key types
Browse files Browse the repository at this point in the history
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
  • Loading branch information
haydentherapper committed Apr 19, 2022
1 parent ab41e0b commit 3698c11
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
3 changes: 2 additions & 1 deletion fulcio.proto
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ message PublicKey {
*/
PublicKeyAlgorithm algorithm = 1;
/*
* PEM encoded public key
* PKIX, ASN.1 DER or PEM-encoded public key. PEM is typically
* of type PUBLIC KEY.
*/
string content = 2 [(google.api.field_behavior) = REQUIRED];
}
Expand Down
5 changes: 3 additions & 2 deletions fulcio_legacy.proto
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ message CreateSigningCertificateRequest {
(google.api.field_behavior) = OPTIONAL
];
/*
* Optional: PKCS#10 encoded certificate signing request
* Optional: PKCS#10 PEM-encoded certificate signing request
* Contains the public key to be stored in the requested
* certificate. All other CSR fields are ignored. Since
* the CSR is self-signed, it also acts as a proof of
Expand All @@ -86,7 +86,8 @@ message PublicKey {
*/
string algorithm = 1 [ deprecated=true ];
/*
* DER or PEM encoded public key
* PKIX, ASN.1 DER or PEM-encoded public key. PEM is typically
* of type PUBLIC KEY.
*/
bytes content = 2 [
deprecated=true,
Expand Down
3 changes: 2 additions & 1 deletion pkg/generated/protobuf/fulcio.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions pkg/generated/protobuf/legacy/fulcio_legacy.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3698c11

Please sign in to comment.