Skip to content

Commit

Permalink
googleca: Don't log all identities
Browse files Browse the repository at this point in the history
Removes logging of all subjects we issue certificates for
from the Google CA backend

Signed-off-by: Nathan Smith <nathan@chainguard.dev>
  • Loading branch information
Nathan Smith committed May 12, 2022
1 parent 170872a commit 5ef98ed
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions pkg/ca/googleca/v1/googleca.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import (
"github.com/sigstore/fulcio/pkg/ca"
"github.com/sigstore/fulcio/pkg/ca/x509ca"
"github.com/sigstore/fulcio/pkg/challenges"
"github.com/sigstore/fulcio/pkg/log"
"github.com/sigstore/sigstore/pkg/cryptoutils"
"google.golang.org/api/iterator"
privatecapb "google.golang.org/genproto/googleapis/cloud/security/privateca/v1"
Expand Down Expand Up @@ -162,8 +161,6 @@ func (c *CertAuthorityService) Root(ctx context.Context) ([]byte, error) {
}

func (c *CertAuthorityService) CreateCertificate(ctx context.Context, subj *challenges.ChallengeResult) (*ca.CodeSigningCertificate, error) {
logger := log.ContextLogger(ctx)

cert, err := x509ca.MakeX509(subj)
if err != nil {
return nil, ca.ValidationError(err)
Expand All @@ -179,8 +176,6 @@ func (c *CertAuthorityService) CreateCertificate(ctx context.Context, subj *chal
return nil, ca.ValidationError(err)
}

logger.Infof("requesting cert from %s for %v", c.parent, subj.Value)

resp, err := c.client.CreateCertificate(ctx, req)
if err != nil {
return nil, err
Expand Down

0 comments on commit 5ef98ed

Please sign in to comment.