Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Issuer interface for spiffe and kubernetes types #1033

Merged
merged 1 commit into from Mar 2, 2023

Conversation

priyawadhwa
Copy link
Contributor

Summary

Release Note

Documentation

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small changes and lgtm
thanks for that

pkg/identity/kubernetes/issuer.go Outdated Show resolved Hide resolved
pkg/identity/spiffe/issuer.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #1033 (ed659aa) into main (123d011) will increase coverage by 0.13%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
+ Coverage   53.82%   53.95%   +0.13%     
==========================================
  Files          41       43       +2     
  Lines        2430     2450      +20     
==========================================
+ Hits         1308     1322      +14     
- Misses       1026     1030       +4     
- Partials       96       98       +2     
Impacted Files Coverage Δ
pkg/identity/kubernetes/issuer.go 70.00% <70.00%> (ø)
pkg/identity/spiffe/issuer.go 70.00% <70.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa priyawadhwa merged commit b2f0dbf into sigstore:main Mar 2, 2023
@priyawadhwa priyawadhwa deleted the more-issuers branch March 2, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants