Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add nil issuers to issuer pool #1053

Merged
merged 1 commit into from Mar 13, 2023

Conversation

priyawadhwa
Copy link
Contributor

There's a chance the issuer can be nil if it's a custom issuer. If it's nil, don't add it to the issuer pool.

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@priyawadhwa priyawadhwa enabled auto-merge (squash) March 13, 2023 21:36
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1053 (42fdd12) into main (372b3f3) will increase coverage by 0.42%.
The diff coverage is 100.00%.

❗ Current head 42fdd12 differs from pull request most recent head 8a322b6. Consider uploading reports for the commit 8a322b6 to get more accurate results

@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
+ Coverage   54.77%   55.20%   +0.42%     
==========================================
  Files          48       48              
  Lines        2521     2525       +4     
==========================================
+ Hits         1381     1394      +13     
+ Misses       1039     1032       -7     
+ Partials      101       99       -2     
Impacted Files Coverage Δ
pkg/server/issuer_pool.go 100.00% <100.00%> (+3.33%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@priyawadhwa priyawadhwa merged commit 7c9cdfe into sigstore:main Mar 13, 2023
@priyawadhwa priyawadhwa deleted the nil-pointer branch March 13, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants