Support SPIFFE challenges instead of just emails. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also refactors the code a bit so each "issuer" can declare which type of subject it will grant. The current types are email and spiffe. Each type can set different fields in the final cert. Signed-off-by: Dan Lorenc <dlorenc@google.com>
dlorenc
changed the title
lukehinds
reviewed
Jun 1, 2021
Closed
priyawadhwa
approved these changes
Jun 1, 2021
lukehinds
approved these changes
Jun 2, 2021
tommyd450
pushed a commit
to tommyd450/fulcio
that referenced
this pull request
Apr 19, 2024
chore(deps): update rhtap references (main)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also refactors the code a bit so each "issuer" can declare which
type of subject it will grant. The current types are email and spiffe.
Each type can set different fields in the final cert.
Signed-off-by: Dan Lorenc dlorenc@google.com