Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/oid-info: clarify source of issuer extensions #1158

Merged
merged 1 commit into from May 7, 2023

Conversation

woodruffw
Copy link
Member

This removes the unconditional statement that the iss claim always appears in this extension, while retaining that behavior for non-federated tokens (and explicitly leaving it ambiguous for federated ones).

CC @haydentherapper

Closes #1145.

Signed-off-by: William Woodruff <william@trailofbits.com>
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #1158 (f4739ef) into main (5f8aec6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1158   +/-   ##
=======================================
  Coverage   56.19%   56.19%           
=======================================
  Files          50       50           
  Lines        2904     2904           
=======================================
  Hits         1632     1632           
  Misses       1129     1129           
  Partials      143      143           

@haydentherapper haydentherapper merged commit 8ff5cb1 into sigstore:main May 7, 2023
13 checks passed
@woodruffw woodruffw deleted the tob-clarify-iss branch May 8, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: clarify the source of the issuer extensions
2 participants