Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure server-side TLS on grpc listener #1252

Merged
merged 2 commits into from Jun 28, 2023

Conversation

bobcallaway
Copy link
Member

Summary

In some deployment scenarios, it may be useful to allow a fulcio instance to listen for gRPC over TLS without the presence of a fronting load balancer. This adds two new command line arguments which allow providing the private key and certificate that can be used to support enabling TLS on the grpc port

Release Note

  • grpc-port can now listen with TLS support using --grpc-tls-certificate and --grpc-tls-key command line arguments

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1252 (1985bd7) into main (8d1b285) will increase coverage by 0.10%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
+ Coverage   56.13%   56.24%   +0.10%     
==========================================
  Files          50       50              
  Lines        2900     2921      +21     
==========================================
+ Hits         1628     1643      +15     
- Misses       1129     1134       +5     
- Partials      143      144       +1     
Impacted Files Coverage Δ
cmd/app/grpc.go 45.94% <78.57%> (+4.64%) ⬆️
cmd/app/serve.go 27.24% <100.00%> (+0.50%) ⬆️

@haydentherapper haydentherapper merged commit c015edd into sigstore:main Jun 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants