New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add HTTP and GRPC health check endpoints #1258
Conversation
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1258 +/- ##
==========================================
+ Coverage 56.07% 56.25% +0.18%
==========================================
Files 50 50
Lines 2921 2940 +19
==========================================
+ Hits 1638 1654 +16
- Misses 1138 1140 +2
- Partials 145 146 +1
|
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
…e grpc Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any tests for this new endpoint? Would be ideal to see both HTTP and gRPC.
The addition in deployment.yaml gets us coverage on both as part of the k8s tests. |
Summary
This adds both HTTP and gRPC health check endpoints to Fulcio.
HTTP:
/healthz
should returnHTTP 200 OK
gRPC: implements gRPC Health Checking Protocol
This also adds coverage for this via K8S local testing using readiness and liveness probes in cluster.
Release Note
Documentation