Expose SkipExpiryCheck OIDC Config Option in Verifier #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyawadhwa
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1271 +/- ##
==========================================
+ Coverage 58.01% 58.23% +0.21%
==========================================
Files 50 50
Lines 3013 3031 +18
==========================================
+ Hits 1748 1765 +17
+ Misses 1113 1110 -3
- Partials 152 156 +4
|
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
|
|
||
| type Issuer interface { | ||
| // Match checks if this issuer can authenticate tokens from a given issuer URL | ||
| Match(ctx context.Context, url string) bool | ||
|
|
||
| // Authenticate ID token and return Principal on success. The ID token's signature | ||
| // is verified in the call -- invalid signature must result in an error. | ||
| Authenticate(ctx context.Context, token string) (Principal, error) | ||
| Authenticate(ctx context.Context, token string, opts ...config.InsecureOIDCConfigOption) (Principal, error) |
There was a problem hiding this comment.
To confirm, this is what you are calling within your code, correct? Just wanted to understand why we need options propagated to all of the issuers.
There was a problem hiding this comment.
Yes! We have a custom issuer which requires this option to be passed in.
| // Look up our fixed issuer verifiers | ||
| v, ok := fc.verifiers[issuerURL] | ||
| if ok { | ||
| return v, true | ||
| for _, c := range v { |
There was a problem hiding this comment.
Is this a use case that needs to be handled? What's the case when you'd have a configuration that specifies both skipping the expiration and not skipping the expiration?
There was a problem hiding this comment.
Yah, so our custom issuer does have this use case. Not sure if I can give more details though 😅
haydentherapper
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes some oidc config options allowed by the go-oidc library that we use, specifically SkipExpiryCheck.
It updates the LRU cache for verifiers to include both the verifier and the config in the cache, so that Verifier A with a normal config can be distinguished from Verifier A with a config with SkipExpiryCheck set