Create interface for GRPC server which encompasses the GRPC HealthServer #1334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated the
NewGRPCCAServer
function to return a struct rather than an interface. I think this was done to make it easier to set up the GRPC health server.We use this function downstream, and it's much more complicated for us to write tests (previously we could mock the
NewGRPCCAServer
function and return a mock interface).This PR basically changes back to returning an interface, and creates a new
GRPCCAServer
which embeds the usual fulcio server and the grpc health check server.