Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interface for GRPC server which encompasses the GRPC HealthServer #1334

Merged
merged 1 commit into from Aug 24, 2023

Conversation

priyawadhwa
Copy link
Contributor

This PR updated the NewGRPCCAServer function to return a struct rather than an interface. I think this was done to make it easier to set up the GRPC health server.

We use this function downstream, and it's much more complicated for us to write tests (previously we could mock the NewGRPCCAServer function and return a mock interface).

This PR basically changes back to returning an interface, and creates a new GRPCCAServer which embeds the usual fulcio server and the grpc health check server.

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1334 (3976a05) into main (d740733) will decrease coverage by 0.10%.
Report is 1 commits behind head on main.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #1334      +/-   ##
==========================================
- Coverage   58.59%   58.49%   -0.10%     
==========================================
  Files          50       50              
  Lines        3053     3053              
==========================================
- Hits         1789     1786       -3     
- Misses       1108     1110       +2     
- Partials      156      157       +1     
Files Changed Coverage Δ
pkg/server/grpc_server.go 50.55% <71.42%> (ø)

... and 1 file with indirect coverage changes

@haydentherapper haydentherapper merged commit e36369c into sigstore:main Aug 24, 2023
13 checks passed
@priyawadhwa priyawadhwa deleted the grpc-server branch August 25, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants