Do not block startup if OIDC provider cannot be created #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sigstore#1358 If a provider is down, this will prevent the service from starting. We now log an error if the provider is down. The service will try to fetch the provider during the next request where that provider is needed. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
+ Coverage 57.56% 57.67% +0.11%
==========================================
Files 50 50
Lines 3111 3112 +1
==========================================
+ Hits 1791 1795 +4
+ Misses 1161 1158 -3
Partials 159 159
|
bobcallaway
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1358
If a provider is down, this will prevent the service from starting. We now log an error if the provider is down. The service will try to fetch the provider during the next request where that provider is needed.
Summary
Release Note
Documentation