Script and process to generate OIDC config from federation directory. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
force-pushed
the
fedcfg
branch
2 times, most recently
from
ec5a007
to
c624067
Compare
|
TODO:
|
dlorenc
force-pushed
the
fedcfg
branch
5 times, most recently
from
eb26809
to
4d17ae5
Compare
dlorenc
changed the title
|
Ref #122 |
lukehinds
reviewed
Jul 19, 2021
Comment on lines
+30
to
36
| "https://oidc.dlorenc.dev": { | ||
| "IssuerURL": "https://oidc.dlorenc.dev", | ||
| "ClientID": "sigstore", | ||
| "Type": "spiffe" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
As this is the main default server config, could there be a fulcio-federated-config.yaml that is used for other specific providers? It could be under federated/config maybe?
There was a problem hiding this comment.
Moved it down a directory! How's this?
There was a problem hiding this comment.
I can't see that, it still seems to be in the main config.json
There was a problem hiding this comment.
So this file is actually generated now (and there's a test to make sure its up to date). The full merged list needs to be in one place. The user-edited ones are now in federation/ and federation/external.
bobcallaway
reviewed
Jul 19, 2021
bobcallaway
approved these changes
Jul 26, 2021
Signed-off-by: Dan Lorenc <dlorenc@google.com>
This was referenced Jul 29, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Lorenc dlorenc@google.com