Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break out CA-specific implementation from common API class #220

Merged
merged 3 commits into from Nov 2, 2021

Conversation

bobcallaway
Copy link
Member

This also causes the configuration to only be read at process initialization rather than on a per-transaction basis.

Fixes #196

Signed-off-by: Bob Callaway bob.callaway@gmail.com

Summary

Ticket Link

Fixes

Release Note


@bobcallaway
Copy link
Member Author

@mattmoor looks like this is related to #222 as well

@mattmoor
Copy link
Member

Oh nice. I'll go through this in a bit (about to pop out for my booster 💉 ).

@dlorenc
Copy link
Member

dlorenc commented Oct 29, 2021

Sorry @bobcallaway, you lost the rebase game :(

Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
@dlorenc dlorenc merged commit 7fb3cb7 into sigstore:main Nov 2, 2021
dlorenc referenced this pull request in dlorenc/fulcio Dec 1, 2021
This got dropped unintentionally during the interface refactor in #218 and #220.

Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
dlorenc pushed a commit that referenced this pull request Dec 1, 2021
This got dropped unintentionally during the interface refactor in #218 and #220.

Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load root CA from HSM at initialization rather than on per-transaction basis
3 participants